bartek/hcpy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Resolves more code review comments

Browse Source
This commit is contained in:
Meatballs1
2024-03-19 13:42:57 +00:00
parent e5550486e2
commit 5307f1cf40
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
HCDevice.py
View File

@@ -122,7 +122,7 @@ class HCDevice:
# check if selected list with values is allowed
if 'values' in feature:
if isinstance(data['value'], int) == False:
if isinstance(data['value'], int) is False:
raise Exception(f"Unable to configure appliance. The value {data['value']} must be an integer. Allowed values are {feature['values']}.")
value = str(data['value']) # values are strings in the feature list, but always seem to be an integer. An integer must be provided
if value not in feature['values']:
@@ -131,7 +131,7 @@ class HCDevice:
if 'min' in feature:
min = int(feature['min'])
max = int(feature['max'])
if isinstance(data['value'], int) == False or data['value'] < min or data['value'] > max:
if isinstance(data['value'], int) is False or data['value'] < min or data['value'] > max:
raise Exception(f"{self.name}. Unable to configure appliance. Value {data['value']} is not a valid value. The value must be an integer in the range {min} and {max}.")
return True
@@ -174,7 +174,7 @@ class HCDevice:
if data is not None:
if action == "POST":
if self.test_feature(data) != True:
if self.test_feature(data) is False:
return
msg["data"] = [data]
else: