8: Fix Decompiler

src/main/java/com/bartek/esa/decompiler/decompiler/Decompiler.java

@@ -1,50 +1,80 @@
 package com.bartek.esa.decompiler.decompiler;
 
-import com.bartek.esa.error.EsaException;
+import com.bartek.esa.decompiler.process.ProcessExecutor;
+import com.bartek.esa.file.cleaner.FileCleaner;
 import com.bartek.esa.file.provider.FileProvider;
-import io.vavr.control.Try;
+import com.bartek.esa.file.zip.ZipTool;
+import org.apache.commons.io.FilenameUtils;
 
 import javax.inject.Inject;
 import java.io.File;
+import java.util.Set;
 
 public class Decompiler {
+    public static final String XML_FILES_DIR = "xml";
+    public static final String JAVA_FILES_DIR = "java";
+
+    private static final String APK_UNZIPPED_DIR = "apk_unzipped";
+    private static final String JAR_FILES_DIR = "jar";
+
     private final FileProvider fileProvider;
+    private final ProcessExecutor processExecutor;
+    private final ZipTool zipTool;
+    private final FileCleaner fileCleaner;
 
     @Inject
-    public Decompiler(FileProvider fileProvider) {
+    public Decompiler(FileProvider fileProvider, ProcessExecutor processExecutor1, ZipTool zipTool, FileCleaner fileCleaner) {
-
         this.fileProvider = fileProvider;
+        this.processExecutor = processExecutor1;
+        this.zipTool = zipTool;
+        this.fileCleaner = fileCleaner;
     }
 
     public File decompile(File inputApk) {
-        File target = provideTargetDirectory();
-        Process process = decompile(inputApk, target);
-        waitForProcess(process);
-        checkExitValue(process);
-        return target;
-    }
-
-    private void checkExitValue(Process process) {
-        if(process.exitValue() != 0) {
-            throw new EsaException("'apktool' process has finished with non-zero code. Interrupting...");
-        }
-    }
-
-    private void waitForProcess(Process process) {
-        Try.run(process::waitFor).getOrElseThrow(EsaException::new);
-    }
-
-    private Process decompile(File inputApk, File target) {
-        return Try.of(() -> Runtime.getRuntime().exec(provideCommandArray(inputApk, target)))
-                    .getOrElseThrow(EsaException::new);
-    }
-
-    private String[] provideCommandArray(File inputApk, File target) {
-        return new String[]{"apktool", "d", inputApk.getAbsolutePath(), "-o", target.getAbsolutePath()};
-    }
-
-    private File provideTargetDirectory() {
         File tmp = fileProvider.createTemporaryDirectory();
-        return new File(tmp, "apktool_out");
+        File javaDirectory = new File(tmp, JAVA_FILES_DIR);
+        File xmlDirectory = new File(tmp, XML_FILES_DIR);
+
+        decompileJavaFiles(inputApk, tmp, javaDirectory);
+        decompileXmlFiles(inputApk, xmlDirectory);
+
+        return tmp;
+    }
+
+    private void decompileJavaFiles(File inputApk, File tmp, File javaDirectory) {
+        File unzippedApkDirectory = new File(tmp, APK_UNZIPPED_DIR);
+        File jarDirectory = new File(tmp, JAR_FILES_DIR);
+
+        zipTool.unzipArchive(inputApk, unzippedApkDirectory);
+
+        Set<File> dexFiles = fileProvider.getGlobMatchedFiles(unzippedApkDirectory.getAbsolutePath(), "**/*.dex");
+        convertDexToJar(dexFiles, jarDirectory);
+
+        Set<File> jarFiles = fileProvider.getGlobMatchedFiles(jarDirectory.getAbsolutePath(), "**/*.jar");
+        decompileJar(jarFiles, javaDirectory);
+
+        fileCleaner.deleteRecursively(unzippedApkDirectory);
+        fileCleaner.deleteRecursively(jarDirectory);
+    }
+
+    private void decompileXmlFiles(File inputApk, File target) {
+        String[] command = {"apktool", "d", inputApk.getAbsolutePath(), "-o", target.getAbsolutePath()};
+        processExecutor.execute(command);
+    }
+
+    private void convertDexToJar(Set<File> dexFiles, File target) {
+        dexFiles.forEach(dex -> {
+            String jarFilename = FilenameUtils.removeExtension(dex.getName()) + ".jar";
+            File jarFile = new File(target, jarFilename);
+            String[] command = {"dex2jar", dex.getAbsolutePath(), "-o", jarFile.getAbsolutePath()};
+            processExecutor.execute(command);
+        });
+    }
+
+    private void decompileJar(Set<File> jarFiles, File target) {
+        jarFiles.forEach(jar -> {
+            String[] command = {"cfr", jar.getAbsolutePath(), "--outputdir", target.getAbsolutePath()};
+            processExecutor.execute(command);
+        });
     }
 }

src/main/java/com/bartek/esa/decompiler/di/DecompilerModule.java

@@ -1,7 +1,10 @@
 package com.bartek.esa.decompiler.di;
 
 import com.bartek.esa.decompiler.decompiler.Decompiler;
+import com.bartek.esa.decompiler.process.ProcessExecutor;
+import com.bartek.esa.file.cleaner.FileCleaner;
 import com.bartek.esa.file.provider.FileProvider;
+import com.bartek.esa.file.zip.ZipTool;
 import dagger.Module;
 import dagger.Provides;
 
@@ -9,7 +12,12 @@ import dagger.Provides;
 public class DecompilerModule {
 
     @Provides
-    public Decompiler decompiler(FileProvider fileProvider) {
+    public ProcessExecutor processExecutor() {
-        return new Decompiler(fileProvider);
+        return new ProcessExecutor();
+    }
+
+    @Provides
+    public Decompiler decompiler(FileProvider fileProvider, ProcessExecutor processExecutor, ZipTool zipTool, FileCleaner fileCleaner) {
+        return new Decompiler(fileProvider, processExecutor, zipTool, fileCleaner);
     }
 }