From df06c7c15cac87090eb8dd8b6f6a59fd053e8b84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Pluta?= Date: Thu, 3 Apr 2025 18:17:56 +0200 Subject: [PATCH] Refactor ING importer --- src/parser/pl/ing/index.ts | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/src/parser/pl/ing/index.ts b/src/parser/pl/ing/index.ts index baaa5e4..3e2ae39 100644 --- a/src/parser/pl/ing/index.ts +++ b/src/parser/pl/ing/index.ts @@ -36,27 +36,21 @@ const headers = [ 'unknown4', ]; -const readIngTransaction = (data: string[]): IngTransaction|undefined => { - if (data.length !== headers.length) { - return; - } - - const transaction: IngTransaction = {}; - headers.forEach((key, index) => { - transaction[key] = data[index].trim(); - }); - - return transaction; -}; - export default class extends BaseTransactionParser { protected requiredFields = []; #transactions: ValidatedIngTransaction[] = []; async pushTransaction(data: string[]): Promise { - const ing = readIngTransaction(data); + if (data.length !== headers.length) { + return false; + } + + const transaction: IngTransaction = {}; + headers.forEach((key, index) => { + transaction[key] = data[index].trim(); + }); - if (!ing) { + if (!transaction) { return false; } @@ -65,18 +59,19 @@ export default class extends BaseTransactionParser { return false; } - const transactionAmount = parseAmount(ing.transactionAmount); - const lockAmount = parseAmount(ing.lockAmount); + const transactionAmount = parseAmount(transaction.transactionAmount); + const lockAmount = parseAmount(transaction.lockAmount); if(transactionAmount === undefined && lockAmount === undefined) { return false; } this.#transactions.push({ - ...ing, + ...transaction, transactionAmount, lockAmount, } as ValidatedIngTransaction); + return true; }